SoundInstances page #174
Merged
SoundInstances page #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into dynamic-sound
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IMB11
added
new-content
|
I this is is well written and should be added |
its-miroma
added
stage:verification
|
Just wondering. Has anyone checked this yet? Otherwise, we can just get rid of this page. |
|
This is incredibly well made. |
IMB11
previously approved these changes
Dec 27, 2024
|
Please can you fix the spotless issues and markdownlint issues present, and then LGTM. |
IMB11
added
stage:ready
its-miroma
approved these changes
Dec 28, 2024
its-miroma
added
stage:ready
|
LGTM @IMB11 |
IMB11
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Issue #70
Content
This page is split into several parts.
The page first explains how to create and use simple SoundInstances and then shows an example of how to make a sound system, which can modulate e.g. its volume and pitch based on the current sound phase and connected BlockEntity values.
Problems & Questions
The current page has not been cleaned up and spellchecked yet. The main reason I'm PRing this now is to ask for opinions.
I was about to delete the 3rd section (starting from the
Advanced SoundInstancesheader) because of the scope of this topic. But it shows how abstract systems can be created. I'm pretty sure this "huge" in-depth example does not belong in the Fabric Docs, but I wanted to hear other opinions before I scrap all of that again.The Choices before I move into the clean-up phase:
This page uses but does not cover BlockEntities and custom S2C networking. Those should be handled on separate pages.